-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update plugin for latest PostCSS #48
Comments
Hi @ai, thanks for the heads up. |
Yeap |
postcss-apply is useful. on the other hand postcss-extend doesn't seem to be maintained. if i want something like Sass @extend, postcss-apply is practical choice for now. it would be great if this plugin is to keep maintained. |
@japboy I will upgrade it to make it work with PostCSS 8 when available. But actually it's closer to postcss-mixins than postcss-extend in behaviour. |
PostCss is already on 8.1.x... how goes this upgrade? Having already completed an upgrade of another small postcss library another myself, the bare minimum changes are pretty minor and should take less than an hour. Taking advantage of the more advanced changes might take a lot longer. If you need someone to simply do the bare minimum, let me know. |
Hi, will be support for postcss v8 added? I see branch |
I've put some effort into getting things working, and have a lot of it slapped together and functional locally, but am very lost when it comes to some of the tests. Some of it seems to be based on how Postcss v7 worked and I don't know exactly how I should move forward. If anyone has a strong opinion I'm all ears, otherwise I'm going to remove things that don't make sense at this point. https://github.com/pascalduez/postcss-apply/blob/master/test/integration.spec.js#L16-L19 |
@spnc-omz That "integration" file aims at testing we don't break other CSS features and PostCSS plugins, mainly |
@pascalduez @spnc-omz do you folks have any update on the progress of the upgrade? @spnc-omz if you have some progress please share your branch, so, I might lend you some help. |
@pascalduez do you have any updates on the progress of this issue? |
WE NEED THIS FOR POSTCSS 8.4 PLEASE @pascalduez |
According this issue PostCSS now parses
--a: { b: 2 }
as--a
declaration with{ b: 2 }
value (CSS Custom Properties requires it from us).We need to update plugin and parse declaration value gain to get its content.
The text was updated successfully, but these errors were encountered: