Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plugin for latest PostCSS #48

Open
ai opened this issue May 4, 2019 · 11 comments
Open

Update plugin for latest PostCSS #48

ai opened this issue May 4, 2019 · 11 comments

Comments

@ai
Copy link

ai commented May 4, 2019

According this issue PostCSS now parses --a: { b: 2 } as --a declaration with { b: 2 } value (CSS Custom Properties requires it from us).

We need to update plugin and parse declaration value gain to get its content.

@pascalduez
Copy link
Owner

Hi @ai,

thanks for the heads up.
If I understand correctly the breakage will happen in PostCSS 8, right?

@ai
Copy link
Author

ai commented May 5, 2019

Yeap

@japboy
Copy link

japboy commented May 5, 2019

postcss-apply is useful. on the other hand postcss-extend doesn't seem to be maintained. if i want something like Sass @extend, postcss-apply is practical choice for now. it would be great if this plugin is to keep maintained.

@pascalduez
Copy link
Owner

pascalduez commented May 5, 2019

@japboy I will upgrade it to make it work with PostCSS 8 when available.

But actually it's closer to postcss-mixins than postcss-extend in behaviour.

@heath-freenome
Copy link

heath-freenome commented Oct 23, 2020

PostCss is already on 8.1.x... how goes this upgrade? Having already completed an upgrade of another small postcss library another myself, the bare minimum changes are pretty minor and should take less than an hour. Taking advantage of the more advanced changes might take a lot longer. If you need someone to simply do the bare minimum, let me know.

@nolimitdev
Copy link

nolimitdev commented Jan 16, 2021

Hi, will be support for postcss v8 added? I see branch feature/postcss-8 https://github.com/pascalduez/postcss-apply/tree/feature/postcss-8 but is it done or is there any technical problem and support for v8 could not be added? Thanks for info. Can someone please explain me what consequence will be without v8 support? I will not be able to update to latest webpack or something else? Postcss-apply depends on postcss v7 so it can work fine forever or not?

@spnc-omz
Copy link

I've put some effort into getting things working, and have a lot of it slapped together and functional locally, but am very lost when it comes to some of the tests.

Some of it seems to be based on how Postcss v7 worked and I don't know exactly how I should move forward. If anyone has a strong opinion I'm all ears, otherwise I'm going to remove things that don't make sense at this point.

https://github.com/pascalduez/postcss-apply/blob/master/test/integration.spec.js#L16-L19

@pascalduez
Copy link
Owner

@spnc-omz That "integration" file aims at testing we don't break other CSS features and PostCSS plugins, mainly postcss-custom-properties, that's exactly what the test you highlight is for. We should leave standard custom properties untouched.

@sevilyilmaz
Copy link

@pascalduez @spnc-omz do you folks have any update on the progress of the upgrade?

@spnc-omz if you have some progress please share your branch, so, I might lend you some help.

@tomasbeloch
Copy link

@pascalduez do you have any updates on the progress of this issue?

@dr-dark-flames
Copy link

WE NEED THIS FOR POSTCSS 8.4 PLEASE @pascalduez

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants