Skip to content

(BSR)[PRO] cleanup after eslint update #7639

(BSR)[PRO] cleanup after eslint update

(BSR)[PRO] cleanup after eslint update #7639

Triggered via pull request November 22, 2024 15:05
Status Cancelled
Total duration 12m 47s
Artifacts 2
Tests pro  /  ...  /  Style quality check
1m 23s
Tests pro / Type check / Quality check / Style quality check
Tests pro  /  Unit tests
8m 1s
Tests pro / Unit tests
[pcapi-tests] build docker image.  /  build-docker-image
[pcapi-tests] build docker image. / build-docker-image
[pcapi] build docker image.  /  build-docker-image
[pcapi] build docker image. / build-docker-image
[pcapi-console] build docker image.  /  Build pcapi-console:04b6ab02c784fb11b8d1624b5a27e651df913957
3m 41s
[pcapi-console] build docker image. / Build pcapi-console:04b6ab02c784fb11b8d1624b5a27e651df913957
MyPy cop  /  MyPy cop test
MyPy cop / MyPy cop test
Tests API documentation  /  Check API documentation can be built
Tests API documentation / Check API documentation can be built
[PRO] Deploy PR version for validation  /  deploy_on_firebase
1m 20s
[PRO] Deploy PR version for validation / deploy_on_firebase
Dependabot  /  dependabot
Dependabot / dependabot
Matrix: Tests api / Pytest
Waiting for pending jobs
Tests api  /  Pylint
Tests api / Pylint
Tests api  /  Quality checks
Tests api / Quality checks
Tests api  /  Test database schema
Tests api / Test database schema
Tests pro E2E  /  E2E tests and notifications
11m 44s
Tests pro E2E / E2E tests and notifications
Update api client template  /  Update API Client template
Update api client template / Update API Client template
Push pcapi docker image to registry  /  push-docker-image
Push pcapi docker image to registry / push-docker-image
Push pcapi-console docker image to registry  /  push-docker-image
Push pcapi-console docker image to registry / push-docker-image
Fit to window
Zoom out
Zoom in

Annotations

10 errors, 14 warnings, and 2 notices
Tests pro / Type check / Quality check / Style quality check: pro/src/app/App/hook/useLogExtraProData.ts#L25
React Hook useEffect has missing dependencies: 'location.pathname', 'logEvent', and 'previousOfferer'. Either include them or remove the dependency array
Tests pro / Type check / Quality check / Style quality check: pro/src/app/App/hook/useLogNavigation.ts#L32
React Hook useEffect has missing dependencies: 'params' and 'previousPage'. Either include them or remove the dependency array
Tests pro / Type check / Quality check / Style quality check: pro/src/app/App/hook/usePageTitle.ts#L16
React Hook useEffect has a missing dependency: 'location'. Either include it or remove the dependency array
Tests pro / Type check / Quality check / Style quality check: pro/src/commons/hooks/useGetBitmap.ts#L21
React Hook useEffect has a missing dependency: 'file'. Either include it or remove the dependency array
Tests pro / Type check / Quality check / Style quality check: pro/src/commons/hooks/useIsElementVisible.ts#L18
The 'observer' object construction makes the dependencies of useEffect Hook (at line 32) change on every render. Move it inside the useEffect callback. Alternatively, wrap the initialization of 'observer' in its own useMemo() Hook
Tests pro / Type check / Quality check / Style quality check: pro/src/commons/hooks/useNotification.ts#L50
React Hook useMemo has a missing dependency: 'notify'. Either include it or remove the dependency array
Tests pro / Type check / Quality check / Style quality check: pro/src/commons/hooks/useRedirectLoggedUser.ts#L53
React Hook useEffect has missing dependencies: 'dispatch', 'navigate', and 'redirectToUrl'. Either include them or remove the dependency array
Tests pro / Type check / Quality check / Style quality check: pro/src/components/Address/Address.tsx#L43
React Hook useEffect has a missing dependency: 'selectedField.value'. Either include it or remove the dependency array
Tests pro / Type check / Quality check / Style quality check: pro/src/components/Address/Address.tsx#L85
React Hook useEffect has missing dependencies: 'addressesMap', 'searchField', and 'setFieldValue'. Either include them or remove the dependency array
Tests pro / Type check / Quality check / Style quality check: pro/src/components/Bookings/Bookings.tsx#L188
React Hook useEffect has missing dependencies: 'initialAppliedFilters.bookingBeginningDate', 'initialAppliedFilters.bookingEndingDate', 'initialAppliedFilters.bookingStatusFilter', and 'initialAppliedFilters.offerEventDate'. Either include them or remove the dependency array
Tests pro / Type check / Quality check / Style quality check
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Tests pro / Type check / Quality check / Style quality check: pro/src/commons/utils/timezone.ts#L56
Switch is not exhaustive. Cases not matched: undefined | null
Tests pro / Type check / Quality check / Style quality check: pro/src/components/Bookings/BookingsRecapTable/BookingsTable/CollectiveActionButtons.tsx#L22
`commons/hooks/useActiveFeature` import should occur before import of `commons/hooks/useNotification`
Tests pro / Type check / Quality check / Style quality check: pro/src/components/Bookings/BookingsRecapTable/BookingsTable/CollectiveActionButtons.tsx#L23
`commons/utils/isActionAllowedOnCollectiveOffer` import should occur before import of `components/CancelCollectiveBookingModal/CancelCollectiveBookingModal`
Tests pro / Type check / Quality check / Style quality check: pro/src/components/Bookings/BookingsRecapTable/BookingsTable/CollectiveBookingsTable.tsx#L38
Switch is not exhaustive. Cases not matched: null | CollectiveBookingsSortingColumn.BENEFICIARY_NAME | CollectiveBookingsSortingColumn.BOOKING_DATE
Tests pro / Type check / Quality check / Style quality check: pro/src/components/Bookings/BookingsRecapTable/BookingsTable/CollectiveTimeLine.tsx#L35
Switch is not exhaustive. Cases not matched: CollectiveBookingCancellationReasons.FRAUD | CollectiveBookingCancellationReasons.FRAUD_SUSPICION | CollectiveBookingCancellationReasons.FRAUD_INAPPROPRIATE | CollectiveBookingCancellationReasons.PUBLIC_API | CollectiveBookingCancellationReasons.FINANCE_INCIDENT | CollectiveBookingCancellationReasons.BACKOFFICE | CollectiveBookingCancellationReasons.BACKOFFICE_EVENT_CANCELLED | CollectiveBookingCancellationReasons.BACKOFFICE_OFFER_MODIFIED | CollectiveBookingCancellationReasons.BACKOFFICE_OFFER_WITH_WRONG_INFORMATION | CollectiveBookingCancellationReasons.BACKOFFICE_OFFERER_BUSINESS_CLOSED | CollectiveBookingCancellationReasons.OFFERER_CONNECT_AS
Tests pro / Type check / Quality check / Style quality check: pro/src/components/Callout/Callout.tsx#L41
Switch is not exhaustive. Cases not matched: CalloutVariant.DEFAULT | CalloutVariant.INFO
Tests pro / Type check / Quality check / Style quality check: pro/src/components/IndividualOffer/utils/getSuccessMessage.ts#L5
Switch is not exhaustive. Cases not matched: OFFER_WIZARD_MODE.READ_ONLY
Tests pro / Unit tests
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
[PRO] Deploy PR version for validation / deploy_on_firebase
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Tests pro E2E / E2E tests and notifications
The following actions use a deprecated Node.js version and will be forced to run on node20: technote-space/workflow-conclusion-action@v3, actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
[PRO] Deploy PR version for validation / deploy_on_firebase
Firebase deployment is available at : https://pc-pro-testing--pr15192-bsr-eslint-fix-error-enmfpvah.web.app
Tests pro E2E / E2E tests and notifications
Running e2e-tests with europe-west1-docker.pkg.dev/passculture-infra-prod/pass-culture-artifact-registry/pcapi:latest

Artifacts

Produced during runtime
Name Size
pass-culture~pass-culture-main~ZBD98V.dockerbuild
93.5 KB
pcapi-console-04b6ab02c784fb11b8d1624b5a27e651df913957.tar Expired
482 MB