(PC-33135)[BO] feat: use Clickhouse for statistics in BO #15153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ogeber-pass
reviewed
Nov 21, 2024
Comment on lines
+338
to
+351
| clickhouse_result = clickhouse_queries.YearlyAggregatedRevenueQuery().execute( | ||
| tuple(venue.id for venue in offerer.managedVenues) | ||
| ) | ||
| details: dict[str, dict] = {} | ||
| future = {"individual": decimal.Decimal(0.0), "collective": decimal.Decimal(0.0)} | ||
| for year, yearly_data in clickhouse_result.income_by_year.items(): | ||
| details[year] = { | ||
| "individual": yearly_data.revenue.individual, # type: ignore[union-attr] | ||
| "collective": yearly_data.revenue.collective, # type: ignore[union-attr] | ||
| } | ||
| future["individual"] += yearly_data.expected_revenue.individual - yearly_data.revenue.individual # type: ignore[union-attr] | ||
| future["collective"] += yearly_data.expected_revenue.collective - yearly_data.revenue.collective # type: ignore[union-attr] | ||
| if sum(future.values()) > 0: | ||
| details["En cours"] = future |
There was a problem hiding this comment.
En fait ça pourrait même valoir le coup de demander à ce qu'il y ait une colonne qui contienne ce calcul directement dans clickhouse
There was a problem hiding this comment.
(je parlais du future j'ai eu la main leste sur la longueur du code à commenter)
There was a problem hiding this comment.
L'idée me semble bonne, on modifiera le code si la table évolue.
ogeber-pass
approved these changes
Nov 21, 2024
prouzet-pass
force-pushed
the
pc-33135-bo-clickhouse
branch
from
ff2502d
to
36e0593
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But de la pull request
Ticket Jira : https://passculture.atlassian.net/browse/PC-33135
Vérifications