Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(PC-33024)[PRO] fix: remove not a11y placeholder #15191

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

(PC-33024)[PRO] fix: remove not a11y placeholder #15191

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion pro/src/components/Address/Address.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
const [selectedField] = useField('addressAutocomplete')
useEffect(() => {
setOptions([{ label: selectedField.value, value: selectedField.value }])
}, [])

Check warning on line 43 in pro/src/components/Address/Address.tsx

View workflow job for this annotation

GitHub Actions / Tests pro / Type check / Quality check / Style quality check 

React Hook useEffect has a missing dependency: 'selectedField.value'. Either include it or remove the dependency array

const onSearchFieldChange = async () => {
if (searchField.value.length >= 3) {
Expand Down Expand Up @@ -114,7 +114,6 @@
<SelectAutocomplete
name="addressAutocomplete"
label="Adresse postale"
placeholder="Entrez votre adresse et sélectionnez une suggestion"
options={options}
hideArrow={true}
resetOnOpen={false}
Expand Down
Loading