Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generator does not account for production mode js minification of the rails asset pipeline. #10

Open
explainer opened this issue Dec 18, 2012 · 3 comments

Comments

@explainer
Copy link
Contributor

When deploying in production mode to heroku, for example, the implicit dependency injection logic of AngularJS gets disabled by the js minification and obfuscation associated with the rails asset pipeline.

It is necessary to use an explicit inject function to define controller parameters.

The temporary work around is to set:

config.assets.compress = false 

in

environments/production.rb

See http://docs.angularjs.org/tutorial/step_05, A Note on Minification, for more information.

@patcito
Copy link
Owner

patcito commented Jan 4, 2013

Brian Ford is working on a minifier that doesn't require doing any hack https://github.com/btford/ngmin

@explainer
Copy link
Contributor Author

Thanks for the info, Patrick. I will check it out.

On 4 January 2013 15:29, Patrick Aljord notifications@github.com wrote:

Brian Ford is working on a minifier that doesn't require doing any hack
https://github.com/btford/ngmin


Reply to this email directly or view it on GitHubhttps://github.com//issues/10#issuecomment-11904830.

Regards,

Ken

Seek wisdom through disbelief

@patcito
Copy link
Owner

patcito commented Jan 4, 2013

I merged your branch and squashed a few of your commits. You'll have to
pull and push --hard to your git repo.

On Sat, Jan 5, 2013 at 12:35 AM, Ken Burgett notifications@github.comwrote:

Thanks for the info, Patrick. I will check it out.

On 4 January 2013 15:29, Patrick Aljord notifications@github.com wrote:

Brian Ford is working on a minifier that doesn't require doing any hack
https://github.com/btford/ngmin


Reply to this email directly or view it on GitHub<
https://github.com/patcito/angularjs_scaffold/issues/10#issuecomment-11904830>.

Regards,

Ken

Seek wisdom through disbelief


Reply to this email directly or view it on GitHubhttps://github.com//issues/10#issuecomment-11904978.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants