Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jgraph graphs do not render in Jupiter lab? #13

Open
smartinsightsfromdata opened this issue Mar 22, 2018 · 5 comments
Open

jgraph graphs do not render in Jupiter lab? #13

smartinsightsfromdata opened this issue Mar 22, 2018 · 5 comments

Comments

@smartinsightsfromdata
Copy link

I run the example notebook in Jupiter notebook and everything works.

I tried to do the same in jupyter lab but the graphs are not rendered.

Any suggestion please?

@leeweizhe1993
Copy link

Same as you @smartinsightsfromdata

@CrashLaker
Copy link

Hi all.

I'm facing the same situation.
Is there a fix to this?

image

image

I'm using chrome
jgraph-0.2.1
jupyter 4.4.0

thanks!

@andy-clapson
Copy link

Same issue here, with the same exception.

@patrickfuller
Copy link
Owner

Quick Fix

Run this in the top notebook cell:

%%bash
wget https://cdnjs.cloudflare.com/ajax/libs/jquery/3.4.1/jquery.js
wget https://cdnjs.cloudflare.com/ajax/libs/require.js/2.3.6/require.js

Jupyter lab no longer imports these libraries by default. This cell should download the files to your lab directory, making them importable.

The Right Fix

These dependencies aren't needed by jgraph and the code could be modified easily enough. (however, I don't want to support two different implementations for notebook and lab.) If there's enough interest in using this library, I can put some time into modifying it. I'm also more than willing to review a PR.

Let me know if this helps!

@andy-clapson
Copy link

hey thanks so much @patrickfuller !
I'll use this fix for the moment, but we may take some time to send up a PR.

I really appreciate the quick response here. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants