Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PF6 custom style followup #4003

Closed
wise-king-sullyman opened this issue May 6, 2024 · 0 comments
Closed

PF6 custom style followup #4003

wise-king-sullyman opened this issue May 6, 2024 · 0 comments

Comments

@wise-king-sullyman
Copy link
Collaborator

Followup to #3966, which commented out some custom styles which were removed in core as a temporary measure to unblock other work.

Noted styling issues:

  • Cookie banner/message needs to have a background.
  • The blue links in the black section at the bottom of the page aren't accessible. Are we keeping the black background I wonder?
  • Get started->Community page - the vertical spacing of sections, headers, etc, is missing
  • I don't see code snippet highlights on react component pages
  • Code snippet highlights run into each other (HTML page) Do we want a little more space or no?
  • Training pages, the cards are messed up https://patternfly-org-pr-3996-site.surge.sh/training/html It looks like instead of a label, we have a tiny card?
  • Utilities - Dark theme dotted outlines on some examples are too light, e.g. https://patternfly-org-pr-3996-site.surge.sh/utility-classes/flex They seem to be good on the layouts.
  • Contrast checker uses hardcoded values
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Extensions May 6, 2024
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues May 6, 2024
@nicolethoen nicolethoen moved this from Needs triage to Backlog in PatternFly Issues Jun 4, 2024
@nicolethoen nicolethoen added this to the Penta beta release milestone Jun 4, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in PatternFly Issues Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Status: Needs triage
Development

No branches or pull requests

2 participants