Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EmptyState in v6 to avoid using Header and Icon subcomponents #4018

Closed
thatblindgeye opened this issue May 14, 2024 · 1 comment · Fixed by #4025
Closed

Update EmptyState in v6 to avoid using Header and Icon subcomponents #4018

thatblindgeye opened this issue May 14, 2024 · 1 comment · Fixed by #4025
Assignees
@thatblindgeye
Milestone
Penta beta release

Comments

@thatblindgeye
Copy link
Contributor

Is this a new page or a change to an existing one?

Describe the enhancement
Looks like before a PR for patternfly/patternfly-react#10130 can go into React, we need to update EmptyState usage in org v6 so that we don't import EmptyStateHeader or EmptyStateIcon.

Are there visuals for this enhancement? If applicable, please include examples for each state and for varying widths
Include screenshots or links to Marvel or other mockups.

Any other information?
@thatblindgeye thatblindgeye self-assigned this May 14, 2024
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues May 14, 2024
@thatblindgeye thatblindgeye added this to the Penta beta release milestone May 14, 2024
@thatblindgeye thatblindgeye moved this from Needs triage to In Progress in PatternFly Issues May 14, 2024
@thatblindgeye thatblindgeye mentioned this issue May 15, 2024
Merged
@thatblindgeye thatblindgeye moved this from In Progress to PR Review in PatternFly Issues May 15, 2024
@thatblindgeye thatblindgeye linked a pull request May 15, 2024 that will close this issue
chore(EmptyState): updated to use props instead of header/icon components #4025
Merged
@jessiehuff jessiehuff moved this from PR Review to Done in PatternFly Issues May 21, 2024
@evwilkin
Copy link
Member

Closed by #4025

@github-project-automation github-project-automation bot moved this from Needs triage to Done in PatternFly Extensions May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thatblindgeye thatblindgeye

Labels
None yet
Projects
PatternFly Issues
Archived in project
PatternFly Extensions
Archived in project
Milestone
Penta beta release
2 participants
@evwilkin @thatblindgeye