Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sankey diagram #10817

Open
kuklas opened this issue Jul 30, 2024 · 5 comments
Open

Sankey diagram #10817

kuklas opened this issue Jul 30, 2024 · 5 comments

Comments

@kuklas
Copy link

kuklas commented Jul 30, 2024

New feature, i dont think PF has this

Describe the feature
We (Cost management) are looking for Sankey diagram. Competitors are using it in Cost world. Cloudability is using it in the True cost explorer
https://technickle.medium.com/thinking-differently-about-sankey-95eae229a82d

PM requested it for the feature, and I believe its useful beyond the feature for everyone that is working with observability. Just not sure about PF and charts, do we create our own or do we use third party?

https://mermaid.js.org/syntax/sankey.html
https://issues.redhat.com/browse/COST-5330

@kuklas
Copy link
Author

kuklas commented Jul 30, 2024

@kuklas
Copy link
Author

kuklas commented Jul 30, 2024

@tlabaj
Copy link
Contributor

tlabaj commented Jul 30, 2024

cc @dlabrecq @andrew-ronaldson

@dlabrecq
Copy link
Member

dlabrecq commented Aug 1, 2024

Victory does not currently support sankey. However, I recommend using Apache ECharts for this particular chart.

I'll take a look at wrapping this chart with our existing PatternFly themes. Customizing tooltips to look like PatternFly will be a challenge.

@pgarciaq
Copy link

pgarciaq commented Aug 5, 2024

I recommend NOT using Mermaid JS, which is completely broken. See mermaid-js/mermaid#5684 and linked issues.

SankeyMatic is open source (ISC license) and worked pretty well for me
https://sankeymatic.com/
https://github.com/nowthis/sankeymatic

@tlabaj tlabaj moved this from Needs triage to Needs info in PatternFly Issues Aug 27, 2024
@tlabaj tlabaj moved this from Needs info to Parking lot in PatternFly Issues Aug 27, 2024
@dlabrecq dlabrecq removed the wontfix label Oct 10, 2024
@patternfly patternfly deleted a comment from github-actions bot Oct 10, 2024
@kmcfaul kmcfaul removed the Feature label Oct 25, 2024
@dlabrecq dlabrecq removed the wontfix label Jan 7, 2025
@patternfly patternfly deleted a comment from github-actions bot Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Parking lot
Development

No branches or pull requests

5 participants