Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fragment parameter HRPs appear to be case sensitive #442

Open
DanGould opened this issue Dec 16, 2024 · 0 comments · May be fixed by #446
Open

Fragment parameter HRPs appear to be case sensitive #442

DanGould opened this issue Dec 16, 2024 · 0 comments · May be fixed by #446
Labels
bug Something isn't working

Comments

@DanGould
Copy link
Contributor

param.starts_with(prefix) is case sensitive and the Url type extended by UrlExt may be mixed case.
@DanGould DanGould added the bug Something isn't working label Dec 16, 2024
DanGould added a commit to DanGould/rust-payjoin that referenced this issue Dec 27, 2024
@DanGould
Fix fragment parameter case sensitivity
c071745 
Bech32 fragment parameters should not be case sensitive. This fixes that
by converting params and bech32 HRPs they match against to uppercase.

Close payjoin#442
@DanGould DanGould linked a pull request Dec 27, 2024 that will close this issue
Draft
DanGould added a commit to DanGould/rust-payjoin that referenced this issue Dec 27, 2024
@DanGould
Fix fragment parameter case sensitivity
4cc0396 
Bech32 fragment parameters should not be case sensitive. This fixes that
by converting params and bech32 HRPs they match against to uppercase.

Close payjoin#442
DanGould added a commit to DanGould/rust-payjoin that referenced this issue Dec 28, 2024
@DanGould
Fix fragment parameter case sensitivity
d3f1e1b 
Bech32 fragment parameters should not be case sensitive. This fixes that
by converting params and bech32 HRPs they match against to uppercase.

Close payjoin#442
DanGould added a commit to DanGould/rust-payjoin that referenced this issue Dec 28, 2024
@DanGould
Fix fragment parameter case sensitivity
dfaf948 
Bech32 fragment parameters should not be case sensitive. This fixes
that by converting params and bech32 Hrp|'1' prefixes they match against
to uppercase.

Note that this implementation implies all fragment parameters must be
case insentitive, which needs to be specified in BIP 77.

Close payjoin#442
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Payjoin Roadmap 📝
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix fragment parameter case sensitivity DanGould/rust-payjoin
1 participant
@DanGould