Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent warning 'ChatService: message with id xxx already exists" #94

Open
juergen83 opened this issue Nov 16, 2021 · 4 comments
Open

Comments

@juergen83
Copy link

Hi, how I can prevent the warning message "ChatService: message with id v0p8zlv7dra already exists" when I login and/or join into a room.
If more and more messages loaded in the chat room then in the browser console appears more and more these warnings.

BR
Juergen

@CodeBast4rd
Copy link
Contributor

@juergen83 we are working on this issue. It comes from not a full implementation of MAM.

But a pull request would be welcome for a log level setting.

@juergen83
Copy link
Author

I thought that this issue comes from MAM. I'll see what can be done...

@juergen83
Copy link
Author

I really want to help you, but I don't have enough knowledge to change your code. I don't know where to place this log level setting.

@CodeBast4rd
Copy link
Contributor

After refactoring the whole code base. I still did not have the success to find out how this issue comes to be.
Here is the line responsible for the warning:
https://github.com/pazznetwork/ngx-chat/blob/master/libs/ngx-chat-shared/src/interface/message-store.ts#L31

In theory this should not happen as the server should now deliver multiple times the same message if not extra queried for it.

I will try to hunt down the error otherwise I will just remove the log.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants