From e019e28bac6016d6944a992c2c8bdec2c642b394 Mon Sep 17 00:00:00 2001 From: tangkong Date: Thu, 18 Jul 2024 11:57:20 -0700 Subject: [PATCH 1/2] BUG: add a newline at end of filestore json file --- superscore/backends/filestore.py | 1 + 1 file changed, 1 insertion(+) diff --git a/superscore/backends/filestore.py b/superscore/backends/filestore.py index 004baf2..628dfcc 100644 --- a/superscore/backends/filestore.py +++ b/superscore/backends/filestore.py @@ -214,6 +214,7 @@ def store(self, root_node: Optional[Root] = None) -> None: try: with open(temp_path, 'w') as fd: json.dump(serialized, fd, indent=2) + fd.write('\n') if os.path.exists(self.path): shutil.copymode(self.path, temp_path) From f1318dff628c957a2d128c2b9beffa95da89aade Mon Sep 17 00:00:00 2001 From: tangkong Date: Thu, 18 Jul 2024 13:35:58 -0700 Subject: [PATCH 2/2] DOC: pre-release notes --- .../63-bug_fs_newline.rst | 22 +++++++++++++++++++ 1 file changed, 22 insertions(+) create mode 100644 docs/source/upcoming_release_notes/63-bug_fs_newline.rst diff --git a/docs/source/upcoming_release_notes/63-bug_fs_newline.rst b/docs/source/upcoming_release_notes/63-bug_fs_newline.rst new file mode 100644 index 0000000..b9a025f --- /dev/null +++ b/docs/source/upcoming_release_notes/63-bug_fs_newline.rst @@ -0,0 +1,22 @@ +63 bug_fs_newline +################# + +API Breaks +---------- +- N/A + +Features +-------- +- N/A + +Bugfixes +-------- +- Add newline to end of file when writing filestore json + +Maintenance +----------- +- N/A + +Contributors +------------ +- tangkong