Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

table height? #12

Closed
tbeason opened this issue Dec 24, 2020 · 4 comments · Fixed by #14
Closed

table height? #12

tbeason opened this issue Dec 24, 2020 · 4 comments · Fixed by #14

Comments

@tbeason
Copy link

tbeason commented Dec 24, 2020

I'm having trouble changing table height. It seems the width is dynamic as I change the window, but I am always stuck with basically a fixed table height (which is very small relative to my available screen real estate). I see there is a height kwarg but I have not successfully used it yet.

@pdeffebach
Copy link
Owner

I just confirmed this on mac. I have no idea how to fix this, though, since this package is just a call to Blink.window. I'll see if I can figure something out.

@jacobadenbaum
Copy link
Contributor

jacobadenbaum commented Apr 18, 2021

I just saw this package, and I immediately noticed this issue. You can fix it by calling showtable with the default argument showtable(df, height = "100vh"). See this issue in TableView. They can't change the default there since it would break the jupyter display, but since this package exclusively uses an electron window, it shouldn't cause any problems here. Happy to make a PR with this fix if it would be helpful! In the interim, you can change this behavior automatically since it looks like browse passes through arbitrary keyword arguments.

@pdeffebach
Copy link
Owner

Oh wonderful!

I will start a PR right away

@jacobadenbaum
Copy link
Contributor

sorry! was 3/4 through the PR when you replied, so I figured I'd just finish it anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants