-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java 17 incompatibility: Unable to make public void sun.nio.ch.ChannelInputStream.close() #268
Comments
Thanks for reporting @mateuszkwiecinski I guess for now we can use an older java version. I've tested it up to JDK 11 and it should work. |
It would be great to revisit this with JDK 17, since that is becoming more normal to use when installing a JDK on an M1 Mac. |
Addressed with #292 |
@Jawnnypoo Apparently, not addressed there either |
So this basically means if I wanna use Shot, I should already give up on that and look for something else? I can't find any workaround for this |
That PR isn't merged. Did you try it with that PR manually? |
Hello, I'm facing same issue on M1 mac. |
There is a work-around you can use until this is fixed: |
Also I'm facing this issue |
* - lates gradle version * - Gradle 8 - Java 17 * - google dependencies * - android machine tag * Fix jacoco deprecated method and testMediumDateTime() * Replace jacoco deprecated enabled with required * Try shot java 17 workaround pedrovgs/Shot#268 * Add comment --------- Co-authored-by: Isabel Martin <arkariang@gmail.com>
Expected behaviour
I can record screenshots on latest LTS java version
Actual behaviour
The build fails with
Full stacktrace
Build scan: https://scans.gradle.com/s/gd3up6bw2wkws/failure#1
Steps to reproduce
./gradlew executeScreenshotTests -Precord
./gradlew executeScreenshotTests -Precord
Version of the library
Add custom folder prefix
The text was updated successfully, but these errors were encountered: