Failing landscape tests due to screen dimensions

[AbdelrahmanTalat]

Expected behaviour

When comparing 2 screenshots in landscape mode the test should pass.

Actual behaviour

When comparing 2 screenshots in landscape mode the test fails with the following response.

 The size of the screenshot taken has changed for test:  [name of the screenshot]
 Original screenshot dimension: 2392x1440.
 New recorded screenshot dimension: 1440x2392.

Steps to reproduce

• I am using API 30 for my screenshots
• I have a tests rule to set the landscape mode using the following code

requestedOrientation = if (BaseCustomViewTestRule.forceLandscape) {
            ActivityInfo.SCREEN_ORIENTATION_LANDSCAPE
        } else {
            ActivityInfo.SCREEN_ORIENTATION_PORTRAIT
        }

Version of the library

5.14.1

[sergio-sastre]

@AbdelrahmanTalat
This is completely unrelated to Shot.
The rotation happens, but asynchronously. Therefore, at the moment you take the screenshot, the rotation has not always finished.

The ugly fix for this is to add a Thread.sleep() before taking the screenshot.
The cleanest way is to implement a testRule that waits for the recreated Activity in the correpsonding orientation to resume.

I provided such a function in this library, which works with Shot and other on-device screenshot testing libraries:
https://github.com/sergio-sastre/AndroidUiTestingUtils