-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom Windows tile #1787
Add custom Windows tile #1787
Conversation
e1c00fc
to
73746ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes looks good to me and as mentioned, it also works as expected. I just have one thing I'd like clarified before approving.
f4c5da1
to
2c82e61
Compare
2c82e61
to
d3ab813
Compare
Sorry for the commit spam, I had to wrestle with the CI a bit… But now everything is working and the PR is ready for review/merge again.
I wrote “for those not yet on Windows 11” in the OP, but perhaps I should have been more explicit, sorry for the confusion. |
Ah that's on me, I managed to skillfully miss the "not yet" part and did exactly what I shouldn't have then 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, merging
Just as it says in the title – a little enhancement for those not yet on Windows 11 which I prepared while working on #848. To try it locally, simply download and extract the Windows artifact from the “Checks” tab of this PR, right-click pencil2d.exe and select “Pin to Start”. This will of course become more useful in conjunction with the installer PR, but it is already functional on its own.
In order to generate the package resource index for the tile images locally, the makepri tool from the Windows SDK must be available – but it is not needed when building only the program itself.