Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom Windows tile #1787

Merged
merged 2 commits into from
Oct 1, 2023
Merged

Conversation

J5lx
Copy link
Member

@J5lx J5lx commented Aug 31, 2023

Just as it says in the title – a little enhancement for those not yet on Windows 11 which I prepared while working on #848. To try it locally, simply download and extract the Windows artifact from the “Checks” tab of this PR, right-click pencil2d.exe and select “Pin to Start”. This will of course become more useful in conjunction with the installer PR, but it is already functional on its own.

In order to generate the package resource index for the tile images locally, the makepri tool from the Windows SDK must be available – but it is not needed when building only the program itself.

@J5lx J5lx force-pushed the enhancements/windows-tile branch from e1c00fc to 73746ce Compare August 31, 2023 17:33
@MrStevns
Copy link
Member

Can confirm it works
image

Well done!

app/app.pro Show resolved Hide resolved
Copy link
Member

@MrStevns MrStevns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes looks good to me and as mentioned, it also works as expected. I just have one thing I'd like clarified before approving.

@J5lx J5lx force-pushed the enhancements/windows-tile branch 2 times, most recently from f4c5da1 to 2c82e61 Compare September 24, 2023 14:44
@J5lx
Copy link
Member Author

J5lx commented Sep 24, 2023

Also since I just noticed your screenshot, this doesn’t actually do anything on Windows 11 since Microsoft removed start menu tiles in that version. On Windows 10, it looks something like this:

image

@MrStevns
Copy link
Member

Also since I just noticed your screenshot, this doesn’t actually do anything on Windows 11 since Microsoft removed start menu tiles in that version. On Windows 10, it looks something like this:

image

Ah... so it's only for Windows 10... well thanks for clarifying that 🤦

@J5lx
Copy link
Member Author

J5lx commented Sep 24, 2023

Sorry for the commit spam, I had to wrestle with the CI a bit… But now everything is working and the PR is ready for review/merge again.

well thanks for clarifying that

I wrote “for those not yet on Windows 11” in the OP, but perhaps I should have been more explicit, sorry for the confusion.

@MrStevns
Copy link
Member

MrStevns commented Sep 24, 2023

I wrote “for those not yet on Windows 11” in the OP, but perhaps I should have been more explicit, sorry for the confusion.

Ah that's on me, I managed to skillfully miss the "not yet" part and did exactly what I shouldn't have then 😅

Copy link
Member

@MrStevns MrStevns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merging

@MrStevns MrStevns merged commit f09d0ca into pencil2d:master Oct 1, 2023
7 checks passed
@J5lx J5lx deleted the enhancements/windows-tile branch October 8, 2023 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants