-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Behavour of initial connect() #18
Comments
I experienced that problem at the beginning when my configuration was wrong, either ip or port because I forgot to change your values. |
If connect() can now raise an exception we need to change the code around both its calls, don't you agree? |
Yes I agree. Now that we have exceptions, we can implement those directly. Would you make a difference between an unreachable host and just a wrong port? unreachable host could be a wrong configuration (or server restart) while a wrong port could be that the server is not running, restarting or the port configuration is wrong but the ip configuration might be right. |
@kevinkk525 You earlier mentioned the behaviour of the initial connect(). If I understand you correctly, there are circumstances in which it can block indefinitely. If this can ever occur it will prevent .bad_wifi() from running so the user has no chance of fixing the situation.
If the above is correct, I think we should get rid of it. I'll document the behaviour and invite users to issue connect() in their bad_wifi() implementation.
The text was updated successfully, but these errors were encountered: