Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable str.partition()/str.rpartition() by default in Unix port (will be still enabled in pycopy-dev) #7

Open
pfalcon opened this issue Dec 10, 2017 · 1 comment
Open

Disable str.partition()/str.rpartition() by default in Unix port (will be still enabled in pycopy-dev) #7

pfalcon opened this issue Dec 10, 2017 · 1 comment

Comments

@pfalcon
Copy link
Owner

pfalcon commented Dec 10, 2017

These functions are superfluous, e.g.:

def partition(s, sep):
    s1, s2 = s.split(sep, 1)
    return (s1, sep, s2)
@pfalcon
Copy link
Owner Author

pfalcon commented Aug 5, 2018

See 56eb25f.

@pfalcon pfalcon changed the title Disable str.partition()/str.rpartition() by default Disable str.partition()/str.rpartition() by default in Unix port (will be still enabled in pycopy-dev) Oct 12, 2019
pfalcon pushed a commit that referenced this issue Dec 2, 2021
@jepler @pfalcon
py/repl: Don't read past the end of import_str.
a8c8213 
asan considers that memcmp(p, q, N) is permitted to access N bytes at each
of p and q, even for values of p and q that have a difference earlier.
Accessing additional values is frequently done in practice, reading 4 or
more bytes from each input at a time for efficiency, so when completing
"non_exist<TAB>" in the repl, this causes a diagnostic:

    ==16938==ERROR: AddressSanitizer: global-buffer-overflow on
    address 0x555555cd8dc8 at pc 0x7ffff726457b bp 0x7fffffffda20 sp 0x7fff
    READ of size 9 at 0x555555cd8dc8 thread T0
        #0 0x7ffff726457a  (/usr/lib/x86_64-linux-gnu/libasan.so.5+0xb857a)
        #1 0x555555b0e82a in mp_repl_autocomplete ../../py/repl.c:301
        #2 0x555555c89585 in readline_process_char ../../lib/mp-readline/re
        #3 0x555555c8ac6e in readline ../../lib/mp-readline/readline.c:513
        #4 0x555555b8dcbd in do_repl /home/jepler/src/micropython/ports/uni
        #5 0x555555b90859 in main_ /home/jepler/src/micropython/ports/unix/
        #6 0x555555b90a3a in main /home/jepler/src/micropython/ports/unix/m
        #7 0x7ffff619a09a in __libc_start_main ../csu/libc-start.c:308
        #8 0x55555595fd69 in _start (/home/jepler/src/micropython/ports/uni

    0x555555cd8dc8 is located 0 bytes to the right of global variable
    'import_str' defined in '../../py/repl.c:285:23' (0x555555cd8dc0) of
    size 8
      'import_str' is ascii string 'import '

Signed-off-by: Jeff Epler <jepler@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pfalcon