Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move eslint package to peerDependencies #93

Open
ljharb opened this issue Aug 26, 2024 · 2 comments
Open

Move eslint package to peerDependencies #93

ljharb opened this issue Aug 26, 2024 · 2 comments
Assignees
@phanect

Comments

@ljharb
Copy link

ljharb commented Aug 26, 2024

It'd be great if you added eslint to peerDependencies, so that npm can programmatically ensure i have a compatible eslint.
@phanect
Copy link
Owner

phanect commented Aug 26, 2024

That sounds reasonable.
When I made this plugin, I added eslint to dependencies because it calls its API, but peerDependencies should be the better option.

@phanect phanect self-assigned this Aug 26, 2024
@phanect phanect changed the title peer deps Move eslint package to peerDependencies Aug 26, 2024
@ljharb
Copy link
Author

ljharb commented Aug 27, 2024

You can add it to both, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phanect phanect

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ljharb @phanect