Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have performance tests run during the build #141

Open
jzonthemtn opened this issue Aug 27, 2024 · 3 comments
Open

Have performance tests run during the build #141

jzonthemtn opened this issue Aug 27, 2024 · 3 comments
Assignees

Comments

@jzonthemtn
Copy link
Member

Have performance tests run during the build and fail the build if a decrease in critical metrics.

@robfromboulder
Copy link
Collaborator

@jzonthemtn wonder if adding phileas-benchmark as a Phileas submodule would make sense?

In the last week or so I've cleaned up phileas-benchmark -- before it had some test cases for issues that we were trying to fix, and some domain-specific filtering logic that I was trying out. (phileas-benchmark is now pretty generic and not as specific to the "resurfaceio" usage of Phileas as it was early on)

Anyway, I was gonna ask you about perhaps moving phileas-benchmark over to the philterd org in GitHub -- but if you're looking to make benchmarking part of the regular build, might be better as a submodule?

ps. Because we have a few other integrations working now, we'll likely be focusing more on end-to-end benchmarking -- so I won't be bothered if phileas-benchmark morphs into something completely different that produces different results. I don't need backwards compatibility here so wouldn't want that to hold us back.

@jzonthemtn
Copy link
Member Author

I think a submodule would be good. If it was Philter with an API I might say a separate repository to build as a docker image and run against the API but I think that's overly complicating it for what there is now. I'd love to include it and set up gates around it!

@jzonthemtn
Copy link
Member Author

The mentioned repository is at https://github.com/philterd/phileas-benchmark.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@robfromboulder @jzonthemtn and others