Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix preCommit Errors for get_class() #118

Open
Chris53897 opened this issue Mar 8, 2024 · 0 comments
Open

Fix preCommit Errors for get_class() #118

Chris53897 opened this issue Mar 8, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@Chris53897
Copy link

Chris53897 commented Mar 8, 2024

Can you please have a look at this Error?
This needs to be fixed to allow people to send PRs.

Class name referenced via call of function get_class().
https://github.com/phly/keep-a-changelog/blob/2.12.x/src/ListenerProvider.php#L167

PHPStrom wants to fix it with $type = $event::class;
But this in only allowed in PHP >= 8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant