clone-repo does not fail for no-existent branches/tags

[keckelt]

Hi,

I had a typo in the branch of one of our components in the phovea_product.json and noticed that there is no error when CircleCI is checking out the repositories.

For example:

      {
        "name": "phovea_security_flask",
        "repo": "phovea/phovea_security_flask",
        "branch": "v666"
      }

Gives the following output

./tmp0_coral running yo phovea:clone-repo
clone repository: git clone -b master --depth 1 https://github.com/Caleydo/coral.git coral
    force ../../.yo-rc-global.json

Your Node.js version 12.22.1 (npm: 6.14.11) matches the required Node.js version 12 (npm: 6). The phovea generator should work as expected.


./tmp0_coral running yo phovea:clone-repo
clone repository: git clone -b v7.0.0 --depth 1 https://github.com/phovea/phovea_clue.git phovea_clue
    force ../../.yo-rc-global.json
./tmp0_coral running yo phovea:clone-repo
clone repository: git clone -b v6.0.0 --depth 1 https://github.com/phovea/phovea_ui.git phovea_ui
    force ../../.yo-rc-global.json
./tmp0_coral running yo phovea:clone-repo
clone repository: git clone -b v666 --depth 1 https://github.com/phovea/phovea_security_flask.git phovea_security_flask
./tmp0_coral running yo phovea:clone-repo
clone repository: git clone -b v9.0.0 --depth 1 https://github.com/datavisyn/phovea_security_store_generated.git phovea_security_store_generated
    force ../../.yo-rc-global.json
./tmp0_coral running yo phovea:clone-repo
clone repository: git clone -b v11.1.0 --depth 1 https://github.com/datavisyn/tdp_core.git tdp_core
    force ../../.yo-rc-global.json
createWorkspace in : ./tmp0_coral/coral
coral
phovea_clue
phovea_security_store_generated
phovea_ui
tdp_core
./tmp0_coral running yo phovea:workspace
Generated workspaces.scss:
...

I've also tried with --serial flag.

The build.js script just continues with installing npm dependencies.