Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent form action attributes #3

Closed
kentr opened this issue Jan 18, 2016 · 3 comments
Closed

Inconsistent form action attributes #3

kentr opened this issue Jan 18, 2016 · 3 comments

Comments

@kentr
Copy link
Collaborator

kentr commented Jan 18, 2016

Possibly a cause of #1 (Authentication doesn't work).

I've noticed that the action attribute of HTML forms varies, and often has bizarre values (such as "/favicon.ico").

The only thing I can imagine causing this is some sort of caching that's not blending requests together.

Update: Looks like Drupal core issue Stop using getMasterRequest() to build $form['#action'] is the likely culprit for this.

Remaining tasks

Fix the patch and test.

@kentr kentr changed the title Inconsistent form behavior Inconsistent forms markup Jan 18, 2016
@kentr
Copy link
Collaborator Author

kentr commented Jan 25, 2016

Looks like Drupal core issue Stop using getMasterRequest() to build $form['#action'] is the likely culprit for this.

The latest patch in that issue wouldn't apply for me.

Next step is to fix the patch and test.

@kentr kentr changed the title Inconsistent forms markup Inconsistent form actions Jan 26, 2016
@kentr
Copy link
Collaborator Author

kentr commented Jan 26, 2016

Stop using getMasterRequest() to build $form['#action'] does appear to fix the problem with inconsistent action attributes, and user login appears to be "working" consistently. This issue should stay open until that one is closed.

There still appears to be a different problem with authentication in general: logging in via one browser resulted in my being logged in automatically when using another browser which should have caused an anonymous visit.

@kentr kentr changed the title Inconsistent form actions Inconsistent form action attributes Jan 26, 2016
@kentr
Copy link
Collaborator Author

kentr commented Feb 16, 2016

Resolved with the patch in the Drupal core issue mentioned above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant