Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No warning message when Zend DTrace is enabled that opcache.jit is implictly disabled #14550

Closed
yangyang198703 opened this issue Jun 13, 2024 · 0 comments

Comments

@yangyang198703
Copy link

Description

When Zend DTrace is enabled via USE_ZEND_DTRACE environment var, turning on opcache.jit would complain about JIT is incompatible with third party extensions that override zend_execute_ex(). JIT disabled.")

The behavior is expected in the code as we check the zend_execute_ex function has been replaced.

if (zend_execute_ex != execute_ex) {
if (strcmp(sapi_module.name, "phpdbg") != 0) {
zend_error(E_WARNING, "JIT is incompatible with third party extensions that override zend_execute_ex(). JIT disabled.");

And it was replaced in the following code when DTRACE is enabled

zend_execute_ex = dtrace_execute_ex;

The problem is that the warning message is not covering this case, and I suggest we should explictly warn users about the DTrace behavior blocking JIT to be enabled.

PHP Version

PHP 8.2.19

Operating System

Any

@nielsdos nielsdos changed the title Enable Zend DTrace will disable opcache.jit implictly No warning message when Zend DTrace is enabled that opcache.jit is implictly disabled Jul 6, 2024
nielsdos added a commit to nielsdos/php-src that referenced this issue Jul 6, 2024
nielsdos added a commit that referenced this issue Jul 7, 2024
* PHP-8.2:
  Fix GH-14550: No warning message when Zend DTrace is enabled that opcache.jit is implictly disabled
nielsdos added a commit that referenced this issue Jul 7, 2024
* PHP-8.3:
  Fix GH-14550: No warning message when Zend DTrace is enabled that opcache.jit is implictly disabled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants