Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View Source link broken in manual pages #437

Open
ta1yaki13 opened this issue Aug 29, 2021 · 8 comments
Open

View Source link broken in manual pages #437

ta1yaki13 opened this issue Aug 29, 2021 · 8 comments

Comments

@ta1yaki13
Copy link

First time submitting an issues to this project.
ViewSource links are broken in Japanese php manual page.
This issues is happening in pt_BR, zh, fr, de, ja, ro, ru, es and tr.

#Procedure
1, open php Documentation page.
2, choose「 Japanese」 from View Online.
3, open Japanese php manual page.
4, push 「ViewSource」 from Japanese php manual page footer.
5, 「404 This is not web page you are looking for.」is displayed.

From ja manual page : https://github.com/php/web-php/blob/master/manual%2Fja%2Findex.php

Regards.

@ta1yaki13 ta1yaki13 changed the title Link broken ViewSource link broken in ja php manual page. Aug 30, 2021
@peterdd
Copy link
Contributor

peterdd commented Sep 3, 2021

Not only ja pages, all other languages except en and deeper nested pages.

@heiglandreas
Copy link
Contributor

The same happened to me for english pages.

I assume that the "show source" does not work here as the pages are not submitted to github when the docs are rendered but provided via a different means.

Instead to see the source of the page one should use the "Create PullRequest" link at the top of the page near the language select-field.

How can we deactivate or point the "View source" to the correct source in the documentation footer?

@salathe
Copy link
Contributor

salathe commented Sep 3, 2021

What is the "source" of a manual page on www.php.net?

@salathe salathe changed the title ViewSource link broken in ja php manual page. View Source link broken in manual pages Sep 3, 2021
@cmb69
Copy link
Member

cmb69 commented Sep 3, 2021

I don't think that the latter makes sense (the browser already offers this "feature"); the former might, if we change the "Submit a Pull Request" link to go to the editor directly (e.g. https://github.com/php/doc-en/edit/master/reference/strings/functions/strlen.xml instead of https://github.com/php/doc-en/blob/master/reference/strings/functions/strlen.xml). Or just drop that "View Source" from the footer.

@salathe
Copy link
Contributor

salathe commented Sep 3, 2021

I don't think that the latter makes sense (the browser already offers this "feature")

If your browser can see the PHP code of manual pages... we've broken our web server.

change the "Submit a Pull Request" link to go to the editor directly (e.g. https://github.com/php/doc-en/edit/master/reference/strings/functions/strlen.xml instead of https://github.com/php/doc-en/blob/master/reference/strings/functions/strlen.xml).

The "edit" link is unfriendly for visitors who are not logged in to GitHub, and was deliberately not used when implementing these links to individual XML files. The current (non-edit) link is better for viewing the source, and the user can choose how they want to edit (clone, edit via the UI if they can, edit via codespaces (press . on the GitHub page), etc.).

Or just drop that "View Source" from the footer.

I'd be 👍 on this for manual pages.

@cmb69
Copy link
Member

cmb69 commented Sep 3, 2021

If your browser can see the PHP code of manual pages... we've broken our web server.

Good point!

The "edit" link is unfriendly for visitors who are not logged in to GitHub, and was deliberately not used when implementing these links to individual XML files.

Ah, that makes sense.

@OlaIola
Copy link

OlaIola commented Feb 6, 2022

I've also stumbled on this while wanting to offer an improvement. It's difficult to contribute this way (

@jimwins
Copy link
Member

jimwins commented Aug 2, 2024

This was "fixed" by #702 (the 'View Source' link was removed from manual pages), but I think incorporating a change like #448 would probably be even better to restore that for consistency with the rest of the site, and because 'Submit a Pull Request' doesn't really convey the same thing even if it's the same URL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants