-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How do you think about a configuration to opt-in to continue the commit if fixer could fix everything automatically? #1132
Comments
Hello there, Thanks for the compliment. I've always been very sceptical for having this feature in Grumphp because I don't want to receive bug reports blaming us that our tool committed unwanted code to their codebase. However, I do agree that having to recommit e.g. cs-fixer changes is a bit tedious. For me, there are 2 ways to go here:
The way I see the configuration option, is something like: grumphp:
fixer:
stage_fixed_files: true This flag would be disabled by default. $stageFixedFilesArguments = $this->processBuilder->createArgumentsForCommand('git');
$stageFixedFilesArguments->add('add');
$stageFixedFilesArguments->addFiles($files);
$process = $this->processBuilder->buildProcess($stageFixedFilesArguments);
$process->run();
// Check result... Alternatively, the configuration could accept context flags like: I think I'm opening up for having this in grumphp's core at this moment in time. |
Thanks for the reply and the hints. Does sound like a little bit more work than I initially would've guessed, but I want to give it a try as soon as I find spare time. :) |
2.5.0
We're using:
The documentation (https://github.com/phpro/grumphp/blob/v2.x/doc/parameters.md ) says:
I actually experience that I always like all the automatic fixes. So if only automatic fixes were done, I'm just used to immediately committing again.
This is a compliment: I just trust Grumphp and the fixer. :)
So I wonder: Could I speed up my workflow by having an new opt-in configuration to continue with the commit if only automatic fixes have been applied?
The text was updated successfully, but these errors were encountered: