-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restarting doesn't remove deleted environment variables in rbenv-vars #2511
Comments
I'm not 100% sure that I agree that this is wrong behaviour in general, though it is certainly unexpected in this case. When you start passenger with This is certainly unexpected when you want the env to be managed by the rbenv-vars file but being able to inherit env vars from the parent process is also an expected capability for passenger. I'd recommend using the |
Removing an environment variable in
.rbenv-vars
file then restarting the app withpassenger-config restart
doesn't work, the variable with its old value persists inENV
.The file attached below contains a test Sinatra app to reproduce the issue.
test.zip
Reproduction Steps
passenger start --daemonize --load-shell-envvars
.curl http://localhost:3000
returnsfoo
, which is expected.FOO
value in.rbenv-vars
file.passenger-config restart-app
and test another request, it returns the new value, that's expected.FOO
inrbenv-vars
file.foo
, that's not expected.Passenger version: 6.0.19
OS: Ubuntu 22.04.2 LTS
The text was updated successfully, but these errors were encountered: