Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meaning of the -z flag #4

Open
pieper opened this issue Apr 18, 2013 · 3 comments
Open

meaning of the -z flag #4

pieper opened this issue Apr 18, 2013 · 3 comments
Assignees

Comments

@pieper
Copy link
Owner

pieper commented Apr 18, 2013

Is the goal of -z to run gzip compression on the files when putting them in the target directory?

@ghost ghost assigned bebbi Apr 18, 2013
@bebbi
Copy link
Collaborator

bebbi commented Apr 18, 2013

yes - gzip or zip. The whole folder tree would be created as without the -z, then as a final pass all files (lowest level, without involving any folders) would be compressed.
Example
result without -z:

doejohn/MR_1
doejohn/MR_2
etc.

with -z:

doejohn/MR.zip or .gz

@pieper
Copy link
Owner Author

pieper commented Apr 18, 2013

Makes sense - let's do .zip then - it's probably the most widely supported format (windows and mac in explorer/finder).

pieper added a commit that referenced this issue Apr 22, 2013
@pieper
Copy link
Owner Author

pieper commented Apr 26, 2013

After looking at this a bit, I'm going to suggest we do it a little differently to remove a layer of directory.

Suppose you had something like:

%PatientName/%StudyDate/%SeriesDescription-%InstanceNumber.dcm

to get files like:

doejohn/2013-04-26/FLAIR-1.dcm

rather than creating a zip like this:

doejohn/2013-04-26/FLAIR.zip

I say we should make a file like this:

doejohn/2013-04-26.zip

The advantage of this is that we don't need to define the format of the zip file name (how do we know to drop the InstanceNumber? It would need to be an extra command line argument, which would be awkward.)

pieper added a commit that referenced this issue Apr 26, 2013
Zip file is created to replace lowest directory level and sorted files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants