Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing issues crashes EuroScope #50

Open
kusterjs opened this issue Nov 20, 2019 · 5 comments
Open

Parsing issues crashes EuroScope #50

kusterjs opened this issue Nov 20, 2019 · 5 comments

Comments

@kusterjs
Copy link

An incorrect formated vSMR configuration file results in an error message followed by a crash of EuroScope. The displayed error message is suitable. However, the behaviour should be that the vSMR radar screen is not loaded (or closed again) and EuroScope keeps running. As the configuration is loaded upon the initialisation of a new vSMR radar display, the file can then be corrected (with ES still running) and then the vSMR display can be loaded properly.
This issue is mainly related to debugging / editing configuration files. An undetected format error can occur quite quickly, and it's just annoying if the application has to be restarted. Such kind of plugin-design-based crashes should be prevented by the plugin itself.

@Keanu73
Copy link
Contributor

Keanu73 commented Dec 2, 2019

I'll see what can be done

@pierr3
Copy link
Owner

pierr3 commented Dec 7, 2019

That’s a good point and that was my initial aim when I wrote this plugin a few years ago, however I remember struggling to achieve that with ES’s framework, it might be possible though. If I can I will take a look.

Sent with GitHawk

@Keanu73
Copy link
Contributor

Keanu73 commented Dec 7, 2019

I was thinking of maybe doing a valid config check before the CPlugin object is passed to EuroScope, therefore not loading the plugin until the config is valid, though not sure if it's the best way to go about it..

hpeter2 added a commit to hpeter2/vSMR that referenced this issue Sep 4, 2020
@hpeter2
Copy link
Contributor

hpeter2 commented Sep 4, 2020

@pierr3 I created some workaround with a default config. EuroScope & vSMR now load correctly without any customization. Nothing will be displayed beside the Topbar, the Inset and Euroscope.

You might also want to apply (a version) of my commit to insert the parsing Error into the MessageBox. #e92a7e7

@pierr3
Copy link
Owner

pierr3 commented Sep 5, 2020

Thanks so much @hpeter2, I will check it out and properly attribute the change to you if I implement!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants