Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: SelectFromMultiSelect -> trim(null) #144

Closed
80Quattro opened this issue Dec 14, 2023 · 1 comment · Fixed by #145
Closed

[Bug]: SelectFromMultiSelect -> trim(null) #144

80Quattro opened this issue Dec 14, 2023 · 1 comment · Fixed by #145
Labels
Bug
Milestone
1.0.10

Comments

@80Quattro
Copy link
Contributor

Expected behavior

SelectFromMultiSelect works also if $value == AbstractFilterType::EMPTY_STRING

Actual behavior

trim(): Argument #1 ($string) must be of type string, null given

An Exception is thrown if $value == AbstractFilterType::EMPTY_STRING in SelectFromMultiSelect

SelectFromMultiSelect.php, line 66 -> There is assigned null to $value,

then, in line 72, function trim($value) is called -> trim(null) is not allowed in PHP: doku

Steps to reproduce
@80Quattro 80Quattro added the Bug label Dec 14, 2023
@80Quattro 80Quattro mentioned this issue Dec 14, 2023
Merged
@kingjia90 kingjia90 added this to the 1.0.10 milestone Jan 10, 2024
@kingjia90
Copy link
Contributor

Thank you!

Fixed by #145

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
1.0.10
Development

Successfully merging a pull request may close this issue.

[BUGFIX] Don't trim value if it's null 80Quattro/ecommerce-framework-bundle
2 participants
@kingjia90 @80Quattro