fix: Environment::setCurrentCheckoutTenant() compares wrong variable #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Environment::setCurrentCheckoutTenant()` should compare the variable it always adjusts in order to detect changes and not the one that is only conditionally adjusted.
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA And hereby will be except from all further pimcore trainings in eternity |
|
recheck |
dvesh3
approved these changes
Oct 16, 2023
|
@das-peter could you please comment again just the CLA line? thanks! |
|
I have read the CLA Document and I hereby sign the CLA |
|
@das-peter one last thing. please rebase it on 1.0 branch. |
|
@das-peter Please create a new PR with your changes from 1.0 or do a force push, to not have all the other commits in your PR. Thanks |
|
pushed directly to 1.0 branch 736a027. thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Environment::setCurrentCheckoutTenant()should compare the variable it always adjusts in order to detect changes and not the one that is only conditionally adjusted.