[Task] Update webpack #211
Conversation
composer.json
Outdated
| @@ -20,7 +20,7 @@ | |||
| "pimcore/personalization-bundle": "^1.0", | |||
| "pimcore/google-marketing-bundle": "^1.0", | |||
| "knplabs/knp-paginator-bundle": "^6.0.0", | |||
| "symfony/webpack-encore-bundle": "^1.13.2", | |||
| "symfony/webpack-encore-bundle": "^1.17", | |||
There was a problem hiding this comment.
@mattamon I think we could support both versions. Also in admin-ui-classic-bundle. WDYT?
| "symfony/webpack-encore-bundle": "^1.17", | |
| "symfony/webpack-encore-bundle": "^1.13.2 || ^2.0", |
There was a problem hiding this comment.
yeah but I would at least already set it to 1.17 so like ^1.17 || ^2.0
|
@mattamon |
Co-authored-by: Jacob Dreesen <j.dreesen@neusta.de>
yeah sorry it was a typo |
|
|
Mhhh, the tests are false positive, because it's still installing the v1, due to personalization bundle which requires an admin ui bundle that doesn't have pimcore/admin-ui-classic-bundle#770 yet |
Resolves #201
Update to 1.17 possible
Restricted due to pimcore/admin-ui-classic-bundle