Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Pimcore 11 / Bug] Admin UI light theme does not contrast with icons #62

Closed
NiklasBr opened this issue Feb 22, 2024 · 9 comments
Closed

[Pimcore 11 / Bug] Admin UI light theme does not contrast with icons #62

NiklasBr opened this issue Feb 22, 2024 · 9 comments

Comments

@NiklasBr
Copy link
Contributor

NiklasBr commented Feb 22, 2024 •
edited
Loading

Related: coreshop/CoreShop#2566

Some icons like:
image

And on hover:
image

... are not compatible with the Admin UI Light theme.
@kingjia90
Copy link
Contributor

Thank you for reporting!

Duplicate of https://github.com/pimcore/admin-ui-classic-light-theme-bundle/issues/4#issuecomment-1832101851
Fixed by https://github.com/pimcore/admin-ui-classic-light-theme-bundle/pull/9

@kingjia90 kingjia90 closed this as not planned Won't fix, can't repro, duplicate, stale Feb 29, 2024
@NiklasBr
Copy link
Contributor Author

404 errors on those links.

@kingjia90
Copy link
Contributor

kingjia90 commented Feb 29, 2024 •
edited
Loading

Ah sorry, they are in private repos
image
but good news is that it will be tagged light-theme 1.0.2 today with the fix

@NiklasBr
Copy link
Contributor Author

Wouldn't it be a lot easier if paying enterprise customers were given access to report these issues as well as issues with other enterprise bundles in their respective repositories?

@kingjia90
Copy link
Contributor

kingjia90 commented Feb 29, 2024 •
edited
Loading

I have no idea as it falls out my direct responsibility (repository settings and SLA stuff), but personally speaking, i am with you on that, i prefer to work directly dev-to-dev on issues/pr instead of getting through jira ticket but the Enterprise World doesn't seem rotating like that 😅

@NiklasBr
Copy link
Contributor Author

NiklasBr commented Mar 5, 2024

[…] but good news is that it will be tagged light-theme 1.0.2 today with the fix

@kingjia90 can you update the documentation to show how we should replicate the fix in Bundles not made by Pimcore?

@kingjia90
Copy link
Contributor

My hands are tied, unless there's an enteprise ticket behind it, the max i can do is open the issue for it, i've also opened one for a class to <body> element to be able to target light theme "natively" in css

@NiklasBr
Copy link
Contributor Author

NiklasBr commented Mar 5, 2024

So it was only halfway fixed?

@kingjia90
Copy link
Contributor

kingjia90 commented Mar 5, 2024 •
edited
Loading

more like not top-priority, unless given different directives

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@NiklasBr @kingjia90