Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: concurrency of gc delete-range #18117

Merged
merged 8 commits into from
Aug 21, 2024

Conversation

ekexium
Copy link
Contributor

@ekexium ekexium commented Jul 25, 2024

First-time contributors' checklist

What is changed, added or deleted? (Required)

Modify the scope of variable tidb_gc_concurrency.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v8.0 (TiDB 8.0 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)

What is the related PR or file link(s)?

pingcap/tidb#54571

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Signed-off-by: ekexium <eke@fastmail.com>
@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 25, 2024
@ekexium ekexium requested a review from qiancai July 25, 2024 05:51
@Oreoxmt Oreoxmt added v8.3 translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. labels Jul 25, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Jul 25, 2024
system-variables.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

system-variables.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 2, 2024
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

system-variables.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 7, 2024
Copy link

ti-chi-bot bot commented Aug 7, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-02 04:12:03.949760135 +0000 UTC m=+62721.168521735: ☑️ agreed by qiancai.
  • 2024-08-07 07:09:42.523990125 +0000 UTC m=+422312.391089213: ☑️ agreed by Oreoxmt.

system-variables.md Outdated Show resolved Hide resolved
qiancai and others added 2 commits August 9, 2024 17:49
Co-authored-by: Aolin <aolinz@outlook.com>
Co-authored-by: Aolin <aolinz@outlook.com>
system-variables.md Outdated Show resolved Hide resolved
@qiancai
Copy link
Collaborator

qiancai commented Aug 19, 2024

/approve

@ti-chi-bot ti-chi-bot bot added the approved label Aug 19, 2024
@qiancai qiancai added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 19, 2024
@ekexium ekexium requested a review from cfzjywxk August 20, 2024 02:49
Signed-off-by: ekexium <eke@fastmail.com>
@ekexium ekexium requested a review from qiancai August 20, 2024 05:25
@qiancai qiancai added the needs-cherry-pick-release-8.3 Should cherry pick this PR to release-8.3 branch. label Aug 20, 2024
@ekexium ekexium requested a review from cfzjywxk August 20, 2024 05:26
system-variables.md Outdated Show resolved Hide resolved
Copy link

ti-chi-bot bot commented Aug 20, 2024

@cfzjywxk: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qiancai
Copy link
Collaborator

qiancai commented Aug 20, 2024

/approve

Copy link

ti-chi-bot bot commented Aug 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@qiancai qiancai removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 21, 2024
@ti-chi-bot ti-chi-bot bot merged commit a6aee72 into pingcap:master Aug 21, 2024
7 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.3: #18401.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-8.3 Should cherry pick this PR to release-8.3 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v8.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants