Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br: add "tiup br debug" command #18161

Merged
merged 7 commits into from
Aug 5, 2024
Merged

br: add "tiup br debug" command #18161

merged 7 commits into from
Aug 5, 2024

Conversation

3pointer
Copy link
Contributor

@3pointer 3pointer commented Jul 26, 2024 •
edited by lilin90
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v8.0 (TiDB 8.0 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 26, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 26, 2024

@BornChanger: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lilin90 lilin90 self-requested a review July 26, 2024 09:13
@lilin90 lilin90 added the translation/doing This PR’s assignee is translating this PR. label Jul 26, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Jul 26, 2024
@lilin90 lilin90 self-assigned this Jul 26, 2024
@lilin90 lilin90 added needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.2 Should cherry pick this PR to release-8.2 branch. labels Jul 26, 2024
lilin90
lilin90 reviewed Jul 26, 2024
View reviewed changes
br/use-br-command-line-tool.md Outdated Show resolved Hide resolved
br/use-br-command-line-tool.md Outdated Show resolved Hide resolved
br/use-br-command-line-tool.md Outdated Show resolved Hide resolved
br/use-br-command-line-tool.md Outdated Show resolved Hide resolved
br/use-br-command-line-tool.md Outdated Show resolved Hide resolved
br/use-br-command-line-tool.md Outdated Show resolved Hide resolved
@lilin90 lilin90 added the ONCALL Relates to documentation oncall. label Jul 26, 2024
@lilin90 lilin90 changed the title br: expose debug command br: add "tiup br debug" command Jul 26, 2024
3pointer and others added 2 commits July 26, 2024 18:15
@3pointer @lilin90
Apply suggestions from code review
1d9ef0c 
Co-authored-by: Lilian Lee <lilin@pingcap.com>
@lilin90
Update wording
7439079
@lilin90 lilin90 mentioned this pull request Aug 5, 2024
Merged
16 tasks
lilin90
lilin90 approved these changes Aug 5, 2024
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 5, 2024
@lilin90 lilin90 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Aug 5, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 5, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 5, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-05 03:54:06.770554253 +0000 UTC m=+237776.637653333: ☑️ agreed by lilin90.
  • 2024-08-05 07:09:58.454109779 +0000 UTC m=+249528.321208867: ☑️ agreed by hfxsd.

@lilin90
Copy link
Member

lilin90 commented Aug 5, 2024

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lilin90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Aug 5, 2024
@ti-chi-bot ti-chi-bot bot merged commit 8473a9a into master Aug 5, 2024
7 checks passed
@ti-chi-bot ti-chi-bot bot deleted the br_validate branch August 5, 2024 07:21
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #18274.

This was referenced Aug 5, 2024
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.2: #18275.

This was referenced Aug 5, 2024
Merged
Merged
ti-chi-bot bot pushed a commit that referenced this pull request Aug 5, 2024
@ti-chi-bot
br: add "tiup br debug" command (#18161) (#18275)
e009cb3
ti-chi-bot bot pushed a commit that referenced this pull request Aug 5, 2024
@ti-chi-bot
br: add "tiup br debug" command (#18161) (#18274)
bc9fbf0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilin90 lilin90 lilin90 approved these changes

@BornChanger BornChanger BornChanger approved these changes

@hfxsd hfxsd hfxsd approved these changes

Assignees

@lilin90 lilin90

Labels
approved lgtm needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.2 Should cherry pick this PR to release-8.2 branch. ONCALL Relates to documentation oncall. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@3pointer @lilin90 @ti-chi-bot @hfxsd @BornChanger