Add tag:environment to AMI filter criteria

[brunoasr]

Summary:

AMI tag 'environment' allow values prod and test. When replacing nodes in Kafka clusters it's important to be able to select AMIs based on their tag 'environment', along with other criteria.

Test Plan:

• Node successfully replaced in dev Orion, using environment=test.

Cluster configuration:

  - clusterId: upgradekafka01
    type: kafka
    configuration:
      image:
        application: kafka
        release: bionic
        architecture: x86_64
        environment: test
        application_environment: dev

Target AMI correctly tagged:

Node replacement successful with correct AMI:

• Node successfully replaced in dev Orion, using environment=prod.

Cluster configuration (no environment, defaults to prod):

  - clusterId: upgradekafka01
    type: kafka
    configuration:
      image:
        application: kafka
        release: bionic
        architecture: x86_64
        application_environment: dev

Target AMI correctly tagged:

Node replacement successful:

brunorodrigues@lancerkafka-canary-0a033c99:~$ tail -f /var/log/orion/orion.log | grep CMDBFallbackReplaceBroker
INFO  [2024-10-02 19:53:49,029] com.pinterest.orion.internal.core.actions.kafka.CMDBFallbackReplaceBrokerAction: Spiffe id exists. Skip userdata update. Existing userdata: #cloud-config
INFO  [2024-10-02 19:53:49,263] com.pinterest.orion.internal.core.actions.kafka.CMDBFallbackReplaceBrokerAction: Current AMI is ami-072a9b7aea157c353
INFO  [2024-10-02 19:53:49,263] com.pinterest.orion.internal.core.actions.kafka.CMDBFallbackReplaceBrokerAction: Image selection config: {application=kafka, release=bionic, architecture=x86_64, application_environment=dev}
INFO  [2024-10-02 19:53:55,845] com.pinterest.orion.internal.core.actions.kafka.CMDBFallbackReplaceBrokerAction: Selected AMI ami-00d45b753bc938156
INFO  [2024-10-02 19:53:55,895] com.pinterest.orion.internal.core.actions.kafka.CMDBFallbackReplaceBrokerAction: EBS volume size override of 25GB requested for:kafka-upgrade01-dev-001