Stop Kafka Service Before Running Broker Recovery Process #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yisheng-zhou
changed the title
| @@ -42,6 +44,7 @@ public class BrokerRecoveryAction extends NodeAction { | |||
| private static final int retryIntervalMilliseconds = 1000; | |||
|
|
|||
| public static final String ATTR_TRY_TO_RESTART_KEY = "try_restart"; | |||
| public static final String ATTR_STOP_SERVICE_BEFORE_REPLACEMENT = "stop_service_before_replacement"; | |||
There was a problem hiding this comment.
Why do we need this? We should always do replacements by stopping the broker first, so no need to make it configurable in my opinion.
| @@ -126,6 +129,37 @@ public void runAction() { | |||
|
|
|||
| getResult().appendOut("Start replacing broker"); | |||
|
|
|||
| // Try to gracefully shutdown service before replacing broker. | |||
| // This can make sure the broker is not the leader of any partition. | |||
There was a problem hiding this comment.
nit: replace this comment with
// This ensures partition leaderships are moved away from the broker before the replacement process starts.
vahidhashemian
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces logic to attempt stopping the Kafka service on a broker before executing other broker recovery actions. This action triggers leadership failover, allowing other brokers to become leaders of Kafka topic partitions.