-
-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Terrain textures disappear #5806
Comments
That's not rendering the patch at all it seems, almost like the culling has decided it isn't visible |
I've not been able to repro' this with some quick local testing around Pallas or Thebe. I also tried with the supplied savegame. @SomenameIchose what GPU do you have? |
|
I gave an another try to fly to Pallas but textures don't disappear this time. Maybe it happens at certain coordinates? |
Yes, I tested it, they disappear at coordinates of S029°25'12 E042°42'07 |
I can reproduce, see the attached save file. Just load it in Pioneer and you should see it. |
Note that it happens both on my integrated Intel card and my discrete Nvidia card (with Nouveau). |
This isn't a GPU/driver bug, this is CPU side terrain generation and the rendering calls itself. Can confirm that it's CPU side only so you'll see it on anything that can run it. |
I can confirm that it's the Horizon Culling optimisation which is... over optimising for some reason 🤷 however nothing appears to have changed in the |
Oof nope that ain't it either, you have found me a real doozy of a bug 🤣 |
Ok, I might have a fix for this in the works but it's after midnight, so I'll continue another day |
I've put in a first draft of a fix in #5829 which will need some serious testing. |
Observed behaviour
When approaching the planet at a certain distance some terrain textures disappear.
![screenshot-20240324-215601](https://private-user-images.githubusercontent.com/154741968/316330647-3a81abda-3c1b-4a00-8691-815ab9e8216f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU5NDE3NjksIm5iZiI6MTcyNTk0MTQ2OSwicGF0aCI6Ii8xNTQ3NDE5NjgvMzE2MzMwNjQ3LTNhODFhYmRhLTNjMWItNGEwMC04NjkxLTgxNWFiOWU4MjE2Zi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwOTEwJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDkxMFQwNDExMDlaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0xMzFhZjJiM2E1YjI2ZTAzZWQwMTRmMTQzNzQxZmNhNmU2OTE4ODIwYjNmZmNmODNkOThmYjk1ODU3ODE0OWQ3JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.Zf8x2EvK8NBFKKmENFA4IETi0JCLvcyXJl3vrXnbjpY)
![screenshot-20240324-215625](https://private-user-images.githubusercontent.com/154741968/316330671-434d3f3d-a077-4f69-8317-b3c552ecb0a4.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU5NDE3NjksIm5iZiI6MTcyNTk0MTQ2OSwicGF0aCI6Ii8xNTQ3NDE5NjgvMzE2MzMwNjcxLTQzNGQzZjNkLWEwNzctNGY2OS04MzE3LWIzYzU1MmVjYjBhNC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwOTEwJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDkxMFQwNDExMDlaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1jNzkwMzZmZmIxZTdmODgyMWI3NTIxZmNhZTFiY2I0N2ZmZDFjMjFmZWE1MjJjMzg3M2RlODExMTA0MjZkNjUwJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.GFRSg_X2IP3kVqqtk1JdIXwvm5mwlAU3UlYQdpwfgjo)
![screenshot-20240324-215536](https://private-user-images.githubusercontent.com/154741968/316330697-c15eb0d6-2f66-4603-ac0e-d4c59d82f741.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU5NDE3NjksIm5iZiI6MTcyNTk0MTQ2OSwicGF0aCI6Ii8xNTQ3NDE5NjgvMzE2MzMwNjk3LWMxNWViMGQ2LTJmNjYtNDYwMy1hYzBlLWQ0YzU5ZDgyZjc0MS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwOTEwJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDkxMFQwNDExMDlaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT00YWVjNzFjNzgzZGI1NDM0NjA1NmY3ZjE3MDczYmZlM2ZmNDE0ZGQ0OWZjMzlkNmVmYjk2OGU2Mjk4NDFkY2RlJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.L_I21kT-HH1GNN4QpWD6HnjivbqcLb8wApgpFUdRMVU)
![screenshot-20240324-215524](https://private-user-images.githubusercontent.com/154741968/316331124-5259e6e8-6304-4518-8460-9194e1c29443.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU5NDE3NjksIm5iZiI6MTcyNTk0MTQ2OSwicGF0aCI6Ii8xNTQ3NDE5NjgvMzE2MzMxMTI0LTUyNTllNmU4LTYzMDQtNDUxOC04NDYwLTkxOTRlMWMyOTQ0My5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwOTEwJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDkxMFQwNDExMDlaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT01NTg0MjM5NDlhZjljMjE5MDExZTZmN2Q1MTZmMmE0NTdmZmM5NjgzZmZmNDlmNjc1OGYxYzQ3M2ExNjE3OTY0JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.MuuQmhuZSDjnJ-WkYHAKsgSmkO9MTt3hL9v0Url6vOY)
On a first screenshot textures are proper
But at some point they(textures) start bugging like this
Expected behaviour
Terrain textures should be stable and shouldn't disappear
Steps to reproduce
Fly up to critical distance to certain planets and moons (in this case it is Pallas, I also saw this bug approaching Thebe)
My pioneer version (and OS):
ver 20240314 (8b6ae92)
OS: Windows 10 Home Edition
My output.txt (required) and game save (optional, but recommended)
output.txt
save.zip
The text was updated successfully, but these errors were encountered: