Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeating Events - Time is off #116

Open
sharked76 opened this issue Feb 28, 2019 · 10 comments
Open

Repeating Events - Time is off #116

sharked76 opened this issue Feb 28, 2019 · 10 comments
Assignees
Labels
Milestone

Comments

@sharked76
Copy link

I setup some events, and I set them to repeat weekly.

When I look at the events they show correctly, for example:

event

event2

You can see in those 2 events, 1 is set for Wednesdays every week from 13:00 to 17:00, the other one is set for Thursdays every week from 18:30 to 21:30

However when you look at the calendar, the 1st entry is correct, but the 1st time it does the repeat its increasing the time by 1 hour. This is happening for all events.

calendar

You can see Monday Club night is set for 19:00 but it changed to 20:00, Trap & Skeet on Sundays is set for 09:00 but it changed to 10:00, etc, etc

Can you advise why the recurring event is increasing by 1 hour?

Thanks
Duane

@pitaj
Copy link
Owner

pitaj commented Feb 28, 2019

Hmmmm interesting, I'll have to look and see if I can reproduce this. I'm thinking it's due to the server being in a different time zone from your computer. Handling dates is really tricky.

@sharked76
Copy link
Author

The server is set to Eastern (EST) the same as my computer

Duane

@sharked76
Copy link
Author

Hi, just wondering if you have any idea how I can fix this issue?

Duane

@pitaj
Copy link
Owner

pitaj commented Mar 2, 2019

I haven't had time to look into it yet

@sharked76
Copy link
Author

sharked76 commented Mar 12, 2019 via email

@pitaj
Copy link
Owner

pitaj commented Mar 12, 2019

That shouldn't be necessary, I'll look into fixing it when I have time.

@sharked76
Copy link
Author

sharked76 commented Mar 12, 2019 via email

@pitaj pitaj self-assigned this Mar 16, 2019
@sharked76
Copy link
Author

Further update to this issue, its still happening and I noticed that when the server adjusts its time automatically from the time server for day light savings time, the existing events in the calendar all become off by 1 hour.

For example, day light savings time will start again next week, once the server changes its time forward, the events in NodeBB will be showing the wrong time in the Calendar view again. If after Daylight savings time is active and I go and delete the event and recreate it, then it shows the correct time, at least until November when the time changes again.

@sharked76
Copy link
Author

Here is an example, you can see the correct start time of 9am on Saturday, however after the server changes to Daylight Savings time, the Calendar some reason changes the time to 10am

image

@pitaj
Copy link
Owner

pitaj commented Mar 11, 2021

I know why this is happening, but fixing it is non-trivial. It will require a pretty big modification to the way datetimes are stored.

@pitaj pitaj added the bug label Mar 11, 2021
@pitaj pitaj added this to the 1.3.0 milestone Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants