Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to merge newest changes of Fullmoon, SQLite etc? #35

Open
xet7 opened this issue Apr 1, 2024 · 2 comments
Open

How to merge newest changes of Fullmoon, SQLite etc? #35

xet7 opened this issue Apr 1, 2024 · 2 comments
Assignees

Comments

@xet7
Copy link

xet7 commented Apr 1, 2024

Hi,
when using Fullmoon at WeKan Studio https://github.com/wekan/wekanstudio , I'm using petclinic changes so that it's safer to use SQLite. Are those changes from your forkable storage branch? Can you merge all newest changes to your master branch? I'm not sure what code belogs where, I got lost when trying to merge code.

I still did not get my code to work, when I tried your example at Discord. This commit added core you suggested:

wekan/wekanstudio@1392d30

If there are newer commits, they may be without those changes, that prevent code from working properly.

@pkulchenko
Copy link
Owner

All the changes from the forkable-storage branch has been merged into the master branch, so you can skip that. To include any recent change, you just need to store fullmoon.lua file in your .lua folder.

I've tried to reproduce the issue we discussed in Discord, but not sure how to set up your project (and I'm not able to log in or register). If you can provide the steps on how to reproduce the issue, I should be able to investigate and fix it. Thanks!

@pkulchenko pkulchenko self-assigned this Apr 21, 2024
@xet7
Copy link
Author

xet7 commented Apr 24, 2024

@pkulchenko

Thanks!

Currently I'm getting these errors:

 adding: templates/welcome.fmt (deflated 28%)
  adding: templates/layout.fmt (deflated 54%)
mv redbean.com wekan.com && \
./wekan.com -s
/zip/.lua/?.lua;/zip/.lua/?/init.lua
/zip/.lua/?.lua;/zip/.lua/?/init.lua;/zip/.lua/?.lua
@/zip/.init.lua
E2024-04-24T04:31:26.337378:/zip/.lua/fullmoon.lua:1372:wekan:288569] (fm) Lua error: attempt to index a nil value
stack traceback:
[C]: in for iterator 'for iterator'
/templates/boards/allboardsList.fmt:64: in field 'content'
/templates/layout.fmt:24: in field 'handler'
/zip/.lua/fullmoon.lua:398: in function 'fullmoon.render'
/templates/boards/allboardsList.fmt:79: in field 'handler'
/zip/.lua/fullmoon.lua:398: in function 'fullmoon.render'
(...tail calls...)
E2024-04-24T04:31:26+000030:tool/net/redbean.c:2601:wekan:288569] (srvr) server error: 500 Internal Server Error
E2024-04-24T04:31:26+115135:tool/net/redbean.c:2601:wekan:288569] (srvr) server error: 404 Not Found

Test this way:

git clone https://github.com/wekan/wekanstudio

cd wekanstudio

git checkout feature-counter

make start

Then webpage at http://localhost:8000/allboards shows:

500 Internal Server Error 

There is no login feature yet. I'm stuck on subtemplates and counter.

Database queries for starboards are here:

https://github.com/wekan/wekanstudio/blob/feature-counter/srv/.lua/routelib.lua#L214

Route is here:

https://github.com/wekan/wekanstudio/blob/feature-counter/srv/.lua/routelib.lua#L245

Counter code is here at template:

https://github.com/wekan/wekanstudio/blob/feature-counter/srv/templates/boards/allboardsList.fmt#L64-L79

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants