Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand tox tests to include recent python 3 releases #37

Open
godber opened this issue Apr 30, 2017 · 3 comments
Open

Expand tox tests to include recent python 3 releases #37

godber opened this issue Apr 30, 2017 · 3 comments

Comments

@godber
Copy link
Member

godber commented Apr 30, 2017

I just noticed that your python 3 tests only go up to 3.4, 3.5 and 3.6 have since released and are in broad use.

https://github.com/planetarypy/pdsview/blob/master/tox.ini#L2

@percurnicus
Copy link
Member

With the new setup, tox will be more difficult...but why does tox need to test more than one python3 version? Aren't they backwards compatible so I should only test 3.6?

@godber
Copy link
Member Author

godber commented May 23, 2017

You make a good case and I would agree that it makes the most sense to test the most recent version if you're only testing one. Maybe in an ideal world you'd test them all. Again, your call at this point 😈

Edit: wording

@percurnicus
Copy link
Member

So I've been going back and forth between what would be a better: only having py2 and py3 as environments which (I think) will pull from the most up to date python2 and python3 on the system or to include many environments and the setting skip_missing_interpreters=True so the tests pass when developers don't have all/multiple versions of 2.x and 3.x. I'm leaning toward the skip_missing_interpreters option because there are somethings that are not full backwards compatible between python 3 versions (Like formatted string literals). Not sure if you have an opinion on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants