Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Label to MVC framework and add find next/prev buttons #44

Open
percurnicus opened this issue Jun 6, 2017 · 0 comments
Open
Assignees

Comments

@percurnicus
Copy link
Member

label.py and textfinder.py need to be refactored into a MVC framework. After refactoring, write some more tests so we can consider label to be stable. There are a couple of tests in test_pdsview.py that test the label but the label tests should be independent of pdsview (in the end there should be a test_label.py). Finally, with the label refactored and tested, create find next and previous buttons in the textfinder.py dialog. Spend some time before moving to MVC to think about how you would add this new feature and test it and you should discover how much of a nightmare that probably would be. After moving to MVC it won't necessarily be easier but should be more clear.

warningtimer.py is a pretty simple example on how the MVC should work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants