Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make eviction restriction parameter more generic to be able to support CRD #98

Open
dbenque opened this issue Sep 30, 2020 · 0 comments

Comments

@dbenque
Copy link
Contributor

dbenque commented Sep 30, 2020

Today we can ask draino to skip eviction on pods controlled by:

  • daemonset
  • statefulset

But there are other type of controlled that we can thinks of and with CRD, the list cannot even be preset.

It would be great to have a parameter that allow us to specify the type of control that we want to consider as exception at eviction time:
replace

		evictDaemonSetPods    = app.Flag("evict-daemonset-pods", "Evict pods that were created by an extant DaemonSet.").Bool()
		evictStatefulSetPods  = app.Flag("evict-statefulset-pods", "Evict pods that were created by an extant StatefulSet.").Bool()

by

                  doNotEvictPodControlledBy = app.Flag("do-not-evict-controlled-by", "Do not evict pods that are controlled by the designated kind").Default(kubernetes.KindStatefulSet,kubernetes.KindDaemonSet).Strings()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant