Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extra space above image in guarantee and people sections on safari #1

Open
rinslvinly opened this issue Feb 15, 2016 · 1 comment
Open

Comments

@rinslvinly
Copy link

I am experiencing a large space between the image and the top of the window on the guarantee and people sections of this site. It seems to work well on chrome and firefox. I added some screenshots.

Thank you for the great tutorials!
screen shot 2016-02-15 at 12 38 43 pm
screen shot 2016-02-15 at 12 38 47 pm

@matochondrion
Copy link

I think this can be fixed by changing the backImage mixin height to use the $height variable instead of being hard coded to 100vh. I didn't notice this negatively affecting anything else?

@define-mixin backImage
  $image,
  $height: 100vh,
  $grstart: rgba(0,0,0,.2),
  $grend: rgba(0,0,0,.5),
  $bgPos: center center {
  background: linear-gradient( to bottom, $grstart, $grend), url($image);
  background-repeat: no-repeat;
  background-position: $bgPos;
  background-size: cover;
  /*height: 100vh; Not sure why height and max-height are different?*/
  height: $height;
  max-height: $height;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants