Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cmd/pscale go install-able #809

Open
marwan-at-work opened this issue Jan 14, 2024 · 1 comment
Open

Make cmd/pscale go install-able #809

marwan-at-work opened this issue Jan 14, 2024 · 1 comment

Comments

@marwan-at-work
Copy link

marwan-at-work commented Jan 14, 2024

It would be great if some of us Go users can install/update the pscale library by just doing go install github.com/planetscale/cli/cmd/pscale@latest

However, due to the 1 replace directive, go install refuses to install binaries that have a replace directive in them:

$ go install github.com/planetscale/cli/cmd/pscale@latest
go: downloading github.com/planetscale/cli v0.177.0
go: github.com/planetscale/cli/cmd/pscale@latest (in github.com/planetscale/cli@v0.177.0):
	The go.mod file for the module providing named packages contains one or
	more replace directives. It must not contain directives that would cause
	it to be interpreted differently than if it were the main module.

Looking at the go.mod file, there's only one replace clause, which seems like a hopefully small lift (by either changing the import path of the fork), or resolving whatever is being replaced upstream would unable this helpful feature.

Thanks!

@dbussink
Copy link
Collaborator

dbussink commented Feb 2, 2024

Sadly cleaning up that replace is a very big lift so not something that’s happening any time soon, if ever to be honest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants