Incorporate model prefix into generated test filenames. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/coverup/coverup.py
Outdated
| @@ -112,7 +112,7 @@ def positive_int(value): | |||
| def test_file_path(test_seq: int) -> Path: | |||
| """Returns the Path for a test's file, given its sequence number.""" | |||
| global args | |||
| return args.tests_dir / f"test_{PREFIX}_{test_seq}.py" | |||
| return args.tests_dir / f"test_{PREFIX}_{args.model.split('/')[0]}_{test_seq}.py" | |||
There was a problem hiding this comment.
How about instead we add a --prefix that replaces the current PREFIX code? Then we could invoke it as --model foo/bar!123 --prefix coverup_foobar without having to worry about invalid characters in the model name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will simplify integration of tests generated using different models.