-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review System #92
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Review requirements should be set at the graph properties top level.
New property
graph.properties.requiredReviewers = Number
When n > 0, any changes to the graph will require n reviewers to approve the changes.
Review user identity is tied to the authentication system. Reviews currently can come from anyone, including the author, because graph changes can happen so easily.
Reviews should be attached to a particular version, and be updatable to a new version. For example, if I review v1234, then a change is made, I should be able to retain the same review but mark it for v1235.
Reviews should be part of the graph's event stream, but should not effect graph state directly, they can effect it by side effect of the approval process, for example if the deploy hook updates the graph with a comment about deployment.
The text was updated successfully, but these errors were encountered: