Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing modes contain and cover (to me at least) #78

Open
petschki opened this issue Jun 1, 2023 · 0 comments
Open

Confusing modes contain and cover (to me at least) #78

petschki opened this issue Jun 1, 2023 · 0 comments
Assignees

Comments

@petschki
Copy link
Member

petschki commented Jun 1, 2023

I just wondered why the plone.scale modes contain and cover are the direct opposite of the css object-fit meanings?

contain

plone.scale fills width/height completely and image gets clipped out of the center
object-fit scales image to fit width or height and gets letterboxed

cover

plone.scale scales image to fit width or height
object-fit fills width/height and gets clipped according to the container

Note to myself: documentation needs update on this too ... see https://6.docs.plone.org/classic-ui/images.html#scaling-direction ... direction is obsolete and should not be used anymore.

@petschki petschki self-assigned this Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant