-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scattergl fill tozerox/y doesn't work as expected #1334
Comments
maybe we should try to make a push for this in #1869 cc @dfcreative |
Also, the "toself" fill option doesn't work as expected. The enclosed area isn't filled. |
Yes, regl-line2d is capable of filling any shapes now, so fully svg-compatible in that sense. We can cover these cases. |
@dfcreative 's regl-based I found a few discrepancies: From https://rreusser.github.io/plotly-mock-viewer/#scatter_fill_no_opacity, applying In https://rreusser.github.io/plotly-mock-viewer/#scatter_fill_self_next, it appears that the bounding lines coloring in gl is blended a little bit. See svg: vs gl (ignore the lack of |
@etpinard 3b08da1 should fix both. Although https://rreusser.github.io/plotly-mock-viewer/#scatter_fill_no_opacity does not fail now, it requires detailed consideration. I get although regular I guess that should be addressed in a separate issue. |
Added mock test d3fd7d2 |
scattergl
filltozeroy
fills to lowest y value rather than 0 and behaves inconsistently fromscatter
fill which uses the trace as a bound (see codepen: http://codepen.io/plotly/pen/apyXpW?editors=1010 )Additionally, we need to fix the attribute description for scattergl
fill
- it should be different from scatter's fill.The text was updated successfully, but these errors were encountered: