Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scattergl plot shapes not working #1372

Closed
ifll opened this issue Feb 13, 2017 · 9 comments
Closed

scattergl plot shapes not working #1372

ifll opened this issue Feb 13, 2017 · 9 comments
Labels
feature something new
Milestone

Comments

@ifll
Copy link

ifll commented Feb 13, 2017

I don't know if it is a known issue but it seems that shapes don't work on scattergl plots.

Here there are two identical code-pens one with svg (scatter plot type) and the other with webgl (scattergl plot type) to demonstrate this issue:

Does anyone know if this will be fixed soon for "scattergl" plots?

I think it is a quite important feature for scatter plots...

Thank you!

@ifll
Copy link
Author

ifll commented Feb 13, 2017

I've seen now it is on the known limitations already: #130
Still, any idea when this could be solved or when those limitations will be planned to be solved?

Webgl is quite more powerful than SVG when plotting a lot of points in scatter plots, so it would be very nice to have same great features as there are in SVG plots...

Thank you!

@etpinard etpinard added the feature something new label Feb 13, 2017
@etpinard etpinard added this to the On-par gl2d milestone Feb 13, 2017
@destradafilm
Copy link

destradafilm commented Mar 15, 2017

@etpinard I forked plotly and made a branch to add more symbols to the scattergl plot. According to the PR guidelines, a maintainer needs to review changes

https://github.com/destradafilm/plotly.js/tree/scattergl-on-par-shapes

@etpinard Sorry, I meant to PR to my own 'master' but sent a PR to plotly

@etpinard
Copy link
Contributor

Thanks for the PR @destradafilm I don't think these are the shapes @ifll was referring to.

@ifll
Copy link
Author

ifll commented Mar 16, 2017

Nope.. by shapes I meant drawing lines and other geometrical figures... I think it is quite easy to check what I meant on the codepens I provided

But anyway, thank you very much @destradafilm for improving scattergl plots :D

@destradafilm
Copy link

Okay, now I'm trying to implement a 'line of best fit' or 'regression line' and need this feature as well

@etpinard
Copy link
Contributor

worth thinking about in #1869

cc @dfcreative

@etpinard
Copy link
Contributor

etpinard commented Jan 8, 2018

Will be fixed by @dfcreative 's regl-based scattergl:

image


We should add a test mock for this thing before merging.

@dy
Copy link
Contributor

dy commented Jan 15, 2018

4287213 adds shapes test mock

@etpinard
Copy link
Contributor

Done in #2258

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature something new
Projects
None yet
Development

No branches or pull requests

4 participants